Improve CliUtils $argv handling #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
added
the
release:fix
weirdan
approved these changes
Dec 26, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to simplify the CliUtils handling by skipping the first value of the
$argvarray when trying to get the arguments and the paths to be checked.I have also added a CliUtils test which covers some basic (and one not so basic) use cases of the two methods I changed. Some parts I couldn't test yet (for example when passing
-as argument, I would have to "mock" STDIN).This also solves an issue with composer 2.2 when the "bin-dir" config is set, because in with the proxies the value in
$argv[0]is not covered anymore in the code where psalm "recognices" itself (the part of the code which I removed completely). See this gist on how to reproduce the issue: https://gist.github.com/vstm/40258de6df2991cf9309cd10e716089b