Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow XdebugHandler version 3 #7211

Merged
merged 3 commits into from
Dec 26, 2021
Merged

Allow XdebugHandler version 3 #7211

merged 3 commits into from
Dec 26, 2021

Conversation

johnstevenson
Copy link
Contributor

composer/xdebug-handler version 3 provides the same functionality as version 2 but removes support for older PHP versions (< 7.2.25). It will be shipped with the impending Composer 2.3 release.

xdebug-handler version 2 will be supported for the lifetime of Composer 2.2 LTS.

@weirdan weirdan changed the title Add XdebugHandler version 3 Allow XdebugHandler version 3 Dec 24, 2021
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 24, 2021
@GrahamCampbell
Copy link

Why is support for v1 dropped? That seems unnecessarily restrictive.

@orklah
Copy link
Collaborator

orklah commented Dec 25, 2021

Why is support for v1 dropped? That seems unnecessarily restrictive.

Yeah, probably some kind of BC break too I believe

@weirdan
Copy link
Collaborator

weirdan commented Dec 25, 2021

Good point about v1. As of now, there's no reason to drop it. @johnstevenson, mind restoring that part?

@johnstevenson
Copy link
Contributor Author

Will do. Sorry about that

@orklah
Copy link
Collaborator

orklah commented Dec 25, 2021

Don't be sorry :) We're not here to always be right :) mistakes are expected, thanks for your contribution, it's very welcome!

@weirdan weirdan merged commit 45c49b5 into vimeo:master Dec 26, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 26, 2021

Thanks!

@johnstevenson johnstevenson deleted the xdebug-handler-3 branch December 27, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants