Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing samesite array attribute #7215

Merged
merged 3 commits into from
Dec 27, 2021
Merged

add missing samesite array attribute #7215

merged 3 commits into from
Dec 27, 2021

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Dec 25, 2021

https://www.php.net/manual/en/function.session-set-cookie-params

When using the second signature, an associative array which may have any of the keys lifetime, path, domain, secure, httponly and samesite. The values have the same meaning as described for the parameters with the same name. The value of the samesite element should be either Lax or Strict. If any of the allowed options are not given, their default values are the same as the default values of the explicit parameters. If the samesite element is omitted, no SameSite cookie attribute is set.

https://www.php.net/manual/en/function.session-set-cookie-params

When using the second signature, an associative array which may have any of the keys lifetime, path, domain, secure, httponly and samesite. The values have the same meaning as described for the parameters with the same name. The value of the samesite element should be either Lax or Strict. If any of the allowed options are not given, their default values are the same as the default values of the explicit parameters. If the samesite element is omitted, no SameSite cookie attribute is set.
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 25, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 25, 2021

You need to update Callmap.php as well, see https://psalm.dev/docs/contributing/editing_callmaps/

@swiffer
Copy link
Contributor Author

swiffer commented Dec 27, 2021

@weirdan done

@weirdan weirdan merged commit 910c34f into vimeo:master Dec 27, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 27, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants