Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "PHP 8.1: Report missing typehints in overridden native methods" #7539

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Jan 31, 2022

Reverts #7363

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Jan 31, 2022
@tm1000
Copy link
Contributor

tm1000 commented Jan 31, 2022

@weirdan what happened with this?

@orklah
Copy link
Collaborator

orklah commented Jan 31, 2022

@tm1000, @weirdan realized removing this would create a BC break and possibly break even more things for people who, for example, started to suppress this issue or possibly plugins that may have already adapted their code.

We'll think about what we'll do, disabling the feature seem a possible way

@weirdan weirdan merged commit dadb1f2 into 4.x Jan 31, 2022
@weirdan weirdan deleted the revert-7363-81_returntypewillchange branch January 31, 2022 23:03
@tm1000
Copy link
Contributor

tm1000 commented Jan 31, 2022

@orklah is there some place you two discuss these things? I originally went to the PR but did not see anything. In open source optics are everything so a long as the user is aware of why their PR was closed its fine but I couldn't find anywhere the reasons for reversion before your comment (this is not an attack FYI I am just honestly curious if there is a place discussion is ongoing about this project)

@weirdan
Copy link
Collaborator Author

weirdan commented Feb 1, 2022

@tm1000, I didn't realize you were asking about the reason to revert the original PR. It's been discussed here: #7518.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants