Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null-type to several DOM-functions #8490

Merged
merged 3 commits into from
Sep 18, 2022
Merged

Conversation

tvdijen
Copy link
Contributor

@tvdijen tvdijen commented Sep 17, 2022

These functions accept null for their namespace-param to use the default namespace.

@orklah
Copy link
Collaborator

orklah commented Sep 18, 2022

Thanks for this!

You must have corresponding changes in Callmap_historical too (or possibly a delta file if those signatures changed in time). The full explanation is here: https://psalm.dev/docs/contributing/editing_callmaps/

@tvdijen
Copy link
Contributor Author

tvdijen commented Sep 18, 2022

Ah great, that was the info I was looking for!
These signatures haven't changed, so I've fixed the historical CallMap as well!

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Sep 18, 2022
@orklah orklah merged commit 8185260 into vimeo:4.x Sep 18, 2022
@orklah
Copy link
Collaborator

orklah commented Sep 18, 2022

Thanks!

@tvdijen tvdijen deleted the setAttributeNS branch September 18, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants