Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct return type of DateTimeImmutable sub method stub #8583

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Correct return type of DateTimeImmutable sub method stub #8583

merged 3 commits into from
Oct 15, 2022

Conversation

gphargreaves
Copy link
Contributor

@gphargreaves gphargreaves commented Oct 14, 2022 •
edited
Loading

Fixes #8484

This tiny tweak corrects the return type of the DateTimeImmutable stub as it doesn't return false.

As seen here sub never returns false and only a clone as mentioned by @AndrolGenhald

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Oct 15, 2022
@orklah orklah merged commit 9218017 into vimeo:4.x Oct 15, 2022
@orklah
Copy link
Collaborator

orklah commented Oct 15, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix DateTimeImmutable::sub() to not return false
2 participants
@gphargreaves @orklah