Allowed taints to pass through urlencode() #8848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found these snippets: https://psalm.dev/r/4c72d132a4<?php // --taint-analysis
system(urlencode($_GET['a'])); |
weirdan
approved these changes
Dec 6, 2022
weirdan
added
the
release:fix
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
urlencode()function currently escapes all taints. I suspect it should only escape html & has_quotes taints. Here's an example where a taint should likely be reported, but is not:https://psalm.dev/r/4c72d132a4
This PR attempts to fix this. Don't hesitate to let me know if I'm missing anything, or if you have any concerns.