Add libxml_get_external_entity_loader to CallMap (PHP 8.2) #8871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It's actually OK and I strongly recommend you provide an array shape for the third callable argument of libxml_set_external_entity_loader and libxml_get_external_entity_loader |
Contributor
Author
|
Array shape added by aced003 |
weirdan
approved these changes
Dec 9, 2022
weirdan
added
internal stubs/callmap
release:feature
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: https://www.php.net/manual/en/function.libxml-get-external-entity-loader.php
PS: not sure how
'(callable(string,string,array):(resource|string|null))|null'syntax readable by psalm. I can even specify array shape here, but the risk to make it unreadable will be even higher. So I've decided to start from a simpler solution.