-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing our Tus upload integration with TusPHP. #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice to see parity between the SDKs. One minor comment, but other than that gj!
'Upload-Offset: {placeholder}', | ||
) | ||
); | ||
$base_url = str_replace($url_path, '', $url); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay for now, imo. But maybe mark this as a #TODO to export into it's own static function that takes in the path and returns all the necessary pieces, as a list or something. For testability and such.
I'm using PHP 7.2 and Vimeo 3.0 but I can't upload big files using tus approach (PATCH). |
With these changes, I was able to upload video files that ranged from 13-793MB large. Since the default PHP memory limit is 128MB, we're uploading in 100MB chunks, so anything larger than what I've tested with should function just as well.
Since this is a breaking change, this'll be tagged released as v3.0.
Resolves #168