-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to stable tus-php, fix psalm warning #211
Conversation
|
Would love to see this merged. |
@SvenSchoene until it's merged, you can use my fork adopt your composer.json like this:
|
@erunion any chance this could get some attention? Lots of downstream packages are blocked by the changes in this PR. Notably |
@jasonmccreary I no longer work at Vimeo so this is all out of my hands unfortunately. I'm not sure who's managing the SDKs since I left, but you can maybe try to contact their support and point them here in the hopes it'll get attention. |
@erunion right on. I'll ping Vimeo Support. Thanks man. 👍 |
Hey everyone, we're reviewing this PR internally and will comment back in this PR when we have any additional news to share! |
@tommypenner hate to be a pain, but any updates here. Seems like a pretty straightforward merge. Would like to use the official repository, but may need to fork if there won't be any progress soon... |
Is there any chance we can get an update on this? It seems it's passed review but the merge is still blocked :( I'd really like to be able to fix a production bug I have but I can't due to the Carbon issue mentioned above. It's been nearly 3 months for 2 tiny changes, it seems long enough to discuss that. Don't mean to be rude or anything but you know.. |
@tommypenner when can this get done? |
Closes #208
assertInternalType
All tests pass, no linting issues, testing locally now.
Considering issue #189 I guess this update might break some functionality so I'd suggest