Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to stable tus-php, fix psalm warning #211

Merged
merged 1 commit into from
Nov 15, 2019
Merged

update to stable tus-php, fix psalm warning #211

merged 1 commit into from
Nov 15, 2019

Conversation

urakozz
Copy link
Contributor

@urakozz urakozz commented Jun 8, 2019

Closes #208

  • upgraded tus-php to stable version v1.0 (some packages now have depend of carbon ^2.0, which is not allowed in the older tus-php versions)
  • fixed psalm warning for deprecated method call assertInternalType

All tests pass, no linting issues, testing locally now.

Considering issue #189 I guess this update might break some functionality so I'd suggest

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@urakozz
Copy link
Contributor Author

urakozz commented Jun 25, 2019

Just FYI, I already signed this CLA 3 times, but it still didn't update the state (since it's SAP I can't say I'm surprised the way it works)

image

@SvenSchoene
Copy link

Would love to see this merged.

@urakozz
Copy link
Contributor Author

urakozz commented Jul 14, 2019

@SvenSchoene until it's merged, you can use my fork

adopt your composer.json like this:

  "vimeo/vimeo-api": "^3.1.0"
  },
  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/urakozz/vimeo.php"
    }
  ],

@jasonmccreary
Copy link

@erunion any chance this could get some attention? Lots of downstream packages are blocked by the changes in this PR. Notably vimeo/laravel. Let me know if I can do anything to help.

@erunion
Copy link
Contributor

erunion commented Sep 11, 2019

@jasonmccreary I no longer work at Vimeo so this is all out of my hands unfortunately. I'm not sure who's managing the SDKs since I left, but you can maybe try to contact their support and point them here in the hopes it'll get attention.

@jasonmccreary
Copy link

@erunion right on. I'll ping Vimeo Support. Thanks man. 👍

@tommypenner
Copy link
Contributor

Hey everyone, we're reviewing this PR internally and will comment back in this PR when we have any additional news to share!

@jasonmccreary
Copy link

@tommypenner hate to be a pain, but any updates here. Seems like a pretty straightforward merge. Would like to use the official repository, but may need to fork if there won't be any progress soon...

@chrisdkemper
Copy link

Is there any chance we can get an update on this? It seems it's passed review but the merge is still blocked :( I'd really like to be able to fix a production bug I have but I can't due to the Carbon issue mentioned above. It's been nearly 3 months for 2 tiny changes, it seems long enough to discuss that. Don't mean to be rude or anything but you know..

@ncatanchin
Copy link

@tommypenner when can this get done?

@nbeliard nbeliard merged commit 1ccd7b3 into vimeo:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tus-php library to version 1.0.0 or higher