Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox 37, styles are broken #139

Closed
gkatsev opened this issue Jan 17, 2015 · 6 comments · Fixed by #165
Closed

Firefox 37, styles are broken #139

gkatsev opened this issue Jan 17, 2015 · 6 comments · Fixed by #165
Assignees
@gkatsev

Comments

@gkatsev
Copy link
Member

gkatsev commented Jan 17, 2015

Or some similar message.
None of the vimperator styles were getting defined on-load.
@gkatsev
Copy link
Member Author

gkatsev commented Jan 17, 2015

Firefox 37 is the current (17 jan 15) aurora build.

@sukima
Copy link
Contributor

sukima commented Jan 17, 2015

Attempted to uninstall and reload. Still broken. Was using the developer edition of FireFox. I'm giving up on the developer edition as the only reason I use FireFox is for vimperator.

@gkatsev
Copy link
Member Author

gkatsev commented Jan 17, 2015

Seems like this is fixed in master. I made another alpha release here: https://github.com/vimperator/vimperator-labs/releases/tag/3.8.3-a4

@sukima can you please try out that XPI and let me know if it fixes it for you as well?

@gkatsev
Copy link
Member Author

gkatsev commented Jan 17, 2015

Going to close this for now.

@gkatsev gkatsev closed this as completed Jan 17, 2015
@sukima
Copy link
Contributor

sukima commented Jan 18, 2015

@gkatsev confirmed https://github.com/vimperator/vimperator-labs/releases/tag/3.8.3-a4 fixes the issue in FireFox Developer Addition.

@gkatsev
Copy link
Member Author

gkatsev commented Feb 1, 2015

Seems like the styles are broken again in: 37.0a2 (2015-02-01)

@gkatsev gkatsev reopened this Feb 1, 2015
@gkatsev gkatsev changed the title Firefox 37, "styles not defined" Firefox 37, styles are broken Feb 1, 2015
@gkatsev gkatsev self-assigned this Feb 1, 2015
gkatsev added a commit that referenced this issue Feb 1, 2015
@gkatsev
Dont redeclare or use let vars improperly
4c9b385 
Fixes #139.
@gkatsev gkatsev mentioned this issue Feb 1, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkatsev gkatsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dont redeclare or use let vars improperly vimperator/vimperator-labs
2 participants
@sukima @gkatsev