Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line iterators #632

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Fix line iterators #632

merged 3 commits into from
Jun 4, 2024

Conversation

vinc
Copy link
Owner

@vinc vinc commented Jun 4, 2024

Now that we can get files from the net it is better to split lines with lines() instead of split('\n') for better interoperability because some documents use \r\n instead of \n as line terminator.

@vinc vinc marked this pull request as ready for review June 4, 2024 12:49
@vinc vinc merged commit 4495b99 into trunk Jun 4, 2024
1 check passed
@vinc vinc deleted the fix/line-iterators branch June 4, 2024 12:50
@vinc vinc mentioned this pull request Jun 4, 2024
@vinc vinc mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant