Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting SLP files through File Processor should be restorable #64

Closed
vinceau opened this issue May 18, 2020 · 0 comments · Fixed by #65
Closed

Deleting SLP files through File Processor should be restorable #64

vinceau opened this issue May 18, 2020 · 0 comments · Fixed by #65
Labels
enhancement New feature or request

Comments

@vinceau
Copy link
Owner

vinceau commented May 18, 2020 •
edited
Loading

Currently when "Delete files with no highlights" option is enabled, the deleted SLP files cannot be restored. This could be incredibly destructive if there was an issue like #63 where combos aren't correctly being matched. It could result in someone essentially losing all their SLP files.

We should use a package like trash to send files to the recycle bin/trash so that users can restore the files if they so wish.

Alternatively, we should add very strong warnings/prompts when a user enables that option.
@vinceau vinceau added the enhancement New feature or request label May 18, 2020
vinceau added a commit that referenced this issue May 20, 2020
@vinceau
Move files to Recycle Bin when deleting. Fixes #64.
611a9b4
@vinceau vinceau mentioned this issue May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare for 1.3.1 vinceau/project-clippi
1 participant
@vinceau