Integrate Devise main + Turbo #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I don't have to install 3.1.2 :D
Remove the previous custom code to make it work with Turbo, as that can interfere with Devise itself and cause other issues. Note that I enforced responders v3.1 in the Gemfile as it's necessary to work with Devise + Turbo, but we could've just updated it via `bundle update responders` too. (this can't be enforced by Devise itself due to compatibility with older Rails versions yet.)
Ideally we'd use `data: { turbo_confirm: "" }`, but this version of
turbo-rails is 1.1.1 which doesn't support that, it requires 1.3.0+, so
I'm just using the more generic `form: { data: { turbo_confirm: "" } }`
version which works for this case.
| @@ -1 +1 @@ | |||
| 3.1.2 | |||
| 3.1.3 | |||
There was a problem hiding this comment.
Feel free to revert these afterwards, just made my life a bit easier :)
This was referenced Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See heartcombo/devise#5558.
@vincemilo I got your app working with Devise main based on the upgrade steps in the changelog/wiki, I do believe the issue was caused by the overrides I mentioned in the issue to make it work with Turbo previously. Since Devise is fully compatible there, those overrides must be removed.
CleanShot.2023-02-17.at.10.33.45.mp4
Let me know if you run into any issues with these changes.