Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to run checks on push and pr to main #35

Merged
merged 3 commits into from
Jan 16, 2021

Conversation

n-peugnet
Copy link
Contributor

@n-peugnet n-peugnet commented Jan 15, 2021

Once this is merged, composer check will be run on each push to main and each pull request targeting main.

Errors to fix before the CI can pass

Fix composer.json

You can check that it is correct using composer validate. To fix it you will first have to add these two fields:

  • name : The property name is required
  • description : The property description is required

You should also fix the license field to reflect the current license: AGPL-3.0-or-later

Then run composer update --lock to update the lockfile and get rid of the following error:

The lock file is not up to date with the latest changes in composer.json

Fix the last phpcs errors

composer fix

Example commit that fixes the CI

n-peugnet@746957c

Successful run: https://github.com/n-peugnet/antilope/actions/runs/488601692

Linked Issues

Fixes #17

@vincent-peugnet vincent-peugnet merged commit 18a4d0e into vincent-peugnet:main Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPStan ? PHPCS ? GH Actions ?
2 participants