Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored CSVReader/first-class support for handling variable column rows #80

Merged
merged 37 commits into from
Mar 12, 2020

Conversation

vincentlaucsb
Copy link
Owner

  • Refactored actual CSV parsing logic out of CSVReader
    • This logic is now located in internals::parse()
    • This refactor also allowed me to get rid of CSVGuesser and replace it with a more succinct function
  • CSV parser now has first-class support files with variable columns instead of forcing users to override bad_row_handler() (which has been removed)
  • Reorganized unit tests
  • parse() now returns a CSVReader instead of a std::deque<CSVRow>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant