Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnprototest: reworking runner to use the unix socket #227

Merged
merged 8 commits into from
Jun 19, 2024

Conversation

vincenzopalazzo
Copy link
Owner

@vincenzopalazzo vincenzopalazzo commented May 19, 2024

See commits for more details

Some comits are cherry-pick inside the #225

Fixes #139
Fixes #132
Fixes #182 (this is a proof of concept that proof that we work, but if was fixed in #242))
Fixes #226 (See the skip tests)
Fixes #228

@vincenzopalazzo vincenzopalazzo added the 👾 - lnprototest Issue related to the lnptototest label May 19, 2024
@vincenzopalazzo vincenzopalazzo added this to the v24.06 milestone May 19, 2024
@vincenzopalazzo vincenzopalazzo added the 👀 - seeking reviews This PR is seeking reviews label May 19, 2024
@vincenzopalazzo
Copy link
Owner Author

Rebasing on top of main that include #225 now

@vincenzopalazzo vincenzopalazzo force-pushed the macros/lnprototest-unix-rpc branch 13 times, most recently from c6eec93 to 80a7701 Compare June 4, 2024 15:01
@vincenzopalazzo vincenzopalazzo added the ⏭️ - next Regarding the next branch label Jun 19, 2024
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo changed the base branch from main to next June 19, 2024 07:20
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo
Copy link
Owner Author

This was acked in private by @Psycho-Pirate :)

@vincenzopalazzo vincenzopalazzo merged commit b1ec657 into next Jun 19, 2024
1 check passed
@vincenzopalazzo vincenzopalazzo deleted the macros/lnprototest-unix-rpc branch June 19, 2024 07:24
@vincenzopalazzo vincenzopalazzo mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👾 - lnprototest Issue related to the lnptototest ⏭️ - next Regarding the next branch 👀 - seeking reviews This PR is seeking reviews
Projects
None yet
1 participant