Fix: Next-line char on unsuppported impls #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- next-line character is only supported on SBCL - other implementations: (code-char 133)
|
Ah. So, a first move would be to make it easy for us to test on several implementations locally, and then, put the tests on a shell script and on CI. |
|
CI sounds like a good idea. Additional options:
|
|
indeed. It's already on UL: https://ultralisp.org/projects/vindarel/cl-str |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next-linecharacter is only supported on SBCL(code-char 133)This fixes issues introduced from #87 : On other implementations than SBCL
#\next-linechar is not supported and therefore breaks them during compilation.Unfortunately this is now included in the recent Quicklisp release ...