Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add in rule for number (#44) #53

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: add in rule for number (#44) #53

merged 1 commit into from
May 20, 2024

Conversation

FACON-Nicolas
Copy link
Contributor

πŸ”— Linked issue

#44

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #44

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly. (not yet, but I'll do it if the pull request is merged)

@RomainLanz RomainLanz merged commit 72912af into vinejs:develop May 20, 2024
6 checks passed
@RomainLanz
Copy link
Member

Thanks!

@RomainLanz
Copy link
Member

Can you do a PR for the documentation?

@FACON-Nicolas
Copy link
Contributor Author

Yes, of course, I do it

@thetutlage
Copy link
Contributor

Fantastic contribution @FACON-Nicolas . Can you please also add the inRule to the list of rules on the Schema class. Precisely here. https://github.com/vinejs/vine/blob/develop/src/schema/number/main.ts#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine Number AND Enum
3 participants