Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#8) Fix environment failures and add environment to CONTRIBUTING.md #9

Merged
merged 2 commits into from
Oct 19, 2020
Merged

(#8) Fix environment failures and add environment to CONTRIBUTING.md #9

merged 2 commits into from
Oct 19, 2020

Conversation

jvfe
Copy link
Contributor

@jvfe jvfe commented Oct 18, 2020 •
edited
Loading

Changes made:

  • Added jupyter-lab and black to the conda environment, though they aren't direct code dependencies, they are necessary for development (Code styling and tutorials)
  • Made a platform-agnostic conda environment.yml, this is done by omitting the builds when exporting (conda env export -f environment.yml --no-builds). Which should be the way to go from now on.
  • Added notes on the contribution guidelines on how to install and update the development environment.

@jvfe
Make environment.yml platform-agnostic
61b6022 
Now collaborators on Linux and OS-X can download the environment and run
it locally. To ensure it's kept the same way, run conda env export with
the --no-builds parameter.

* Closes #8
@jvfe
Add notes about conda on CONTRIBUTING.md
2763973 
Should address the changes made by f9361f1 and
61b6022.
@vinisalazar
Copy link
Owner

Looks good to me, thank you very much @jvfe !

@vinisalazar vinisalazar merged commit 408582a into vinisalazar:master Oct 19, 2020
@vinisalazar vinisalazar added the hacktoberfest-accepted contributions to the Hacktoberfest event label Oct 19, 2020
@jvfe jvfe deleted the fix_environment branch October 19, 2020 21:34
vinisalazar added a commit that referenced this pull request Apr 26, 2021
@vinisalazar
Improve environment.yml
4881b00 
  - Remove builds (#9)
  - Change name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted contributions to the Hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvfe @vinisalazar