-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import json2xml.json2xml causes an error #209
Comments
Hi @nrathaus, I am sorry that I missed this issue. Now coming to the issue at hand, the new version of Json2xml which is 5.0.x has dropped support for Python3.9. It is mentioned in the release notes here (https://github.com/vinitkumar/json2xml/releases/tag/v5.0.0) https://endoflife.date/python (states that the active support for Python3.9 has already ended). If possible, I would recommend to upgrade to a newer version of Python, if not, it's better to stick to 4.x version of Json2xml. I am anyways going to backport any new feature or security fixes to at least 4.x version of Json2xml. If there are any questions, please don't hesitate to ask. |
Thank you for explaining it It would be a good idea to make the module aware that it's incompatible via its setup file, at the moment pip will happily install it on python3.9 setups Unfortunately for me, it's an old system (raspberry based) which I can't upgrade to the latest version |
@nrathaus You are right, I indeed missed doing it while I thought I did that. Thanks for the suggestion. I will implement it and do a new release. |
Thanks for the hard work |
Hi @nrathaus Thanks again for pointing this mistake. As corrective measures, I have made two PRS: And am currently doing a new release to PyPI. The latest version should be 5.0.4. Could you please check by installing latest json2xml and see if you see the correct warning: Please run this on a Python3.9 env or virtualenv. pip install --upgrade json2xml Once you are satisfied with the solution, please close this issue and don't hesitate to open another ticket should you have another issue with json2xml. Have a great day ahead. 🥂 |
Env
Python 3.9.2 (default, Mar 12 2021, 04:06:34)
[GCC 10.2.1 20210110] on linux
Version
json2xml-5.0.2
Linux
Linux 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux
Expected behavior
No error
Observed behavior
Other env using ./venv/lib/python3.10/site-packages/json2xml-4.1.0.dist-info
Upgrading to 5.0.2 on working env (still fails)
Downgrading from
5.
to4.
worksThe text was updated successfully, but these errors were encountered: