Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get record change route #1368

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Aravindh-Raju
Copy link
Member

Fixes #1367.

Changes in this pull request:

  • Removed the unnecessary segment to avoid any confusion as it's not used anywhere. Change the route a bit to match the other recordsetchange routes.

@Aravindh-Raju Aravindh-Raju self-assigned this May 23, 2024
@Aravindh-Raju Aravindh-Raju added kind/maintenance Code cleanup, refactoring, upgrading to new shiny things area/api Items relating to the API labels May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (372e7db) to head (ddd31fa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1368   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         177      177           
  Lines        7947     7947           
  Branches      257      238   -19     
=======================================
  Hits         7312     7312           
  Misses        635      635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nspadaccino nspadaccino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested API locally

@nspadaccino nspadaccino added this to the v0.20.2 milestone Jul 18, 2024
@arpit4ever arpit4ever modified the milestones: v0.20.2, v0.22.0 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Items relating to the API kind/maintenance Code cleanup, refactoring, upgrading to new shiny things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Get Recordset Change Route
3 participants