Adding volumes and adding openssh-clients for ssh access to hosts. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgege
requested changes
Sep 19, 2018
Dockerfile
Outdated
| RUN yum -y install epel-release && yum update -y | ||
| VOLUME ["/opt/backup", "/opt/omd/sites"] | ||
|
|
||
| RUN yum -y install epel-release && yum update -y && yum install openssh-clients |
There was a problem hiding this comment.
This doesn't work because the build is not interactive --> you have to use yum -y install
But please add the openssh-clients to the yum install some lines down where there are already some additional packets listed (ssmtp, which)
There was a problem hiding this comment.
Yep I figured the -y later on. I'm gonna correct that, however I'm unsure as to how to add these changes to the pull request. Let me try to figure it out
|
As discussed in #24 we'll leave out the volumes right now - for openssh please open a separate pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the image to be recreated without explicitly having to provide volumes.
Also installs openssh-client, which allows check_mk to connect to hosts using ssh (rather than using plaintext, unauthenticated access over the internet)