Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional mailhub encryption and authentication to bootstrap.sh #40

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

spamverdacht
Copy link
Contributor

add optional mailhub encryption and authentication to bootstrap.sh

@spamverdacht
Copy link
Contributor Author

oops..?!? I can find my README.md changes on https://hub.docker.com/r/nlmacamp/check_mk/ before this pull request was accepted!

@mcgege
Copy link
Collaborator

mcgege commented Sep 30, 2018

@viper0131 Can you please check the docker settings? I have no access to this ...

@mcgege mcgege mentioned this pull request Sep 30, 2018
@viper0131
Copy link
Owner

master branch will be build and result in a 'snapshot
tags will be build in to tag name
all other branches won't be build anymore.

Copy link
Collaborator

@mcgege mcgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it in my environment ... it seems like ssmtp is switching the authentication on when you define AuthUser or AuthPass (even if the parameter is empty). And as my own mailserver doesn't support authentication, mail delivery fails.

Please change this so that when those parameters are not set, then they must not appear in the config file (or should be commented out).

it seems like ssmtp is switching the authentication on when AuthUser or AuthPass are defined, even if the parameter is empty. Now unsed or empty parameters doesn't appear in the config file.
Copy link
Contributor Author

@spamverdacht spamverdacht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved in commit 88419c7

@mcgege
Copy link
Collaborator

mcgege commented Oct 12, 2018

@spamverdacht Thanks a lot for your contribution!

@mcgege mcgege merged commit d525b61 into viper0131:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants