Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DataPlaneSpec to the IO-spec #230

Merged
merged 14 commits into from
Oct 18, 2023

Conversation

mlimbeck
Copy link
Collaborator

The IO-spec is rewritten such that it depends on an abstract verison of the dataplane. This is needed to provide additional ghost state. Also the IO-spec uses now the match clause, making it easier to read and a closer match to the IO-spec from Isabelle. Finally, all unrequired functions are commented out.

verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/router_events.gobra Outdated Show resolved Hide resolved
verification/io/router_events.gobra Outdated Show resolved Hide resolved
verification/io/xover.gobra Outdated Show resolved Hide resolved
verification/io/xover.gobra Outdated Show resolved Hide resolved
verification/io/xover.gobra Outdated Show resolved Hide resolved
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments. I guess we can merge it after you are done with them

verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/dataplane_abstract.gobra Show resolved Hide resolved
verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/dataplane_abstract.gobra Outdated Show resolved Hide resolved
verification/io/io-spec.gobra Show resolved Hide resolved
verification/io/io-spec.gobra Outdated Show resolved Hide resolved
verification/io/io-spec.gobra Outdated Show resolved Hide resolved
verification/io/router.gobra Outdated Show resolved Hide resolved
verification/io/xover.gobra Outdated Show resolved Hide resolved
@jcp19 jcp19 requested a review from Dspil October 17, 2023 22:37
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We can merge it when the tests go through, unless @Dspil has a different opinion

@jcp19 jcp19 merged commit 10676f7 into viperproject:master Oct 18, 2023
4 checks passed
@mlimbeck mlimbeck deleted the rewrite-IO-spec branch December 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants