-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refutation support #583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurel300
reviewed
Jun 7, 2022
mschwerhoff
reviewed
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, mostly a few minor comments.
src/main/scala/viper/silver/plugin/standard/refute/RefuteErrors.scala
Outdated
Show resolved
Hide resolved
src/main/scala/viper/silver/plugin/standard/refute/RefuteErrors.scala
Outdated
Show resolved
Hide resolved
mschwerhoff
approved these changes
Jun 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo a few minor comments
src/main/scala/viper/silver/plugin/standard/refute/RefutePlugin.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
refute expr
statement, which is anassert expr
with errors inverted and without assuming anything in the following statements (anassert expr
assumesexpr
afterwards). That is, arefute expr
does not report an error iff anassert expr
would. Note that this is not the same asassert !expr
since both asserts fail in the following snippet:One useful application is to check reachability (e.g. for identifying dead code) since all assertions pass in unreachable code (i.e.
refute false
will only error in dead code).To workaround Silicon's
numberOfErrorsToReport
limit, this PR also adds anExpectFail
info tag to be used on assertions which should not be counted towards the limit (see linked Silicon PR).ExpectFail
should be anabstract class
instead