Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #552 #590

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Fix for issue #552 #590

merged 5 commits into from
Jul 18, 2022

Conversation

marcoeilers
Copy link
Contributor

@marcoeilers marcoeilers commented Jul 2, 2022 •
edited by JonasAlaif
Loading

Fixes #552

@marcoeilers marcoeilers requested a review from vakaras July 4, 2022 12:26
vakaras
vakaras reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@vakaras vakaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Aurel300
Copy link
Member

Aurel300 commented Jul 18, 2022 •
edited
Loading

Can we merge this @JonasAlaif or @marcoeilers ? (Edit: Marco confirmed.)

@Aurel300 Aurel300 merged commit 6246cce into master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakaras vakaras vakaras left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requirement failed in Map lookup
4 participants
@marcoeilers @Aurel300 @vakaras @JonasAlaif