Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters for rhsm, add is_log_cmd to not display cmd. #323

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Add parameters for rhsm, add is_log_cmd to not display cmd. #323

merged 1 commit into from
Aug 11, 2023

Conversation

linl-rh
Copy link
Collaborator

@linl-rh linl-rh commented Aug 7, 2023

  1. Add parameters for rhsm, you can define them in aws.yaml, os-tests.yaml or in cmd line.
  2. Don't display the value of rhsm parameters in test log.
  3. Add is_log_cmd in run_cmd, if you don't want to display the cmd, set is_log_cmd=False in case.

@linl-rh linl-rh requested a review from liangxiao1 August 7, 2023 10:17
liangxiao1
liangxiao1 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@liangxiao1 liangxiao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@liangxiao1 liangxiao1 merged commit 568adc4 into virt-s1:master Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxiao1 liangxiao1 liangxiao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linl-rh @liangxiao1