Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match cdrom more accurate in 'test_wipefs_cdrom' #334

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Match cdrom more accurate in 'test_wipefs_cdrom' #334

merged 1 commit into from
Oct 9, 2023

Conversation

yuxisun1217
Copy link
Collaborator

In LVM file system, lsblk|grep sr may match '/usr' which makes the dev is empty in the first loop.

$ lsblk | grep sr
  ├─rootvg-usrlv  253:3    0   10G  0 lvm  /usr
sr0                11:0    1  628K  0 rom

After fix:

$ lsblk | grep -E 'sr[0-9]'
sr0                11:0    1  628K  0 rom

@yuxisun1217
Match cdrom more accurate
0f8278e 
Signed-off-by: Yuxin Sun <yuxisun@redhat.com>
liangxiao1
liangxiao1 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@liangxiao1 liangxiao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@liangxiao1 liangxiao1 merged commit ecf8156 into virt-s1:master Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxiao1 liangxiao1 liangxiao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuxisun1217 @liangxiao1