Feat isc dhcp #31
Merged
Feat isc dhcp #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this implements #10 everything is a bit hacky and only for testing! I would not recommend using this ldap config in production.
|
|
||
| class DhcpConfig: | ||
| def __init__(self, mac, ip_address, gateway=None, networkmask=None): | ||
| self.mac = mac |
The dhcp hostname will be set automated by socket.getfqdn()
Merged
* You can delete LDAP Entries by DN * You can get LDAP DN by IP and by MAC * You can get all objects of class "dhcpHost"
* Added method to check if ipv4/mac configuration exists * Added delete Method * Added get method for ipv4 and mac * Added a all method to get all stored configurations
* /dhcp endoint have GET,POST * /dhcp/ipv4/<ipv4> endpoint have GET,PUT,DELETE * /dhcp/mac/<mac> endpoint have GET,PUT,DELETE * The gateway and networkmask arguments are not requires anymore
So we can import this config variable from other files
| else: | ||
| self.ip_address = ip_address | ||
|
|
||
| self.dhcp_hostname = socket.getfqdn() |
There was a problem hiding this comment.
How much load will this generate if we have many requests? what about setting the FQDN in the config file and do a fallback to socket.getfqdn() is nothing is set?
|
|
||
| self.set_settings(True, mac, ip_address, gateway, networkmask) | ||
|
|
||
| def set_settings(self, set_not_required_if_none=False, mac=None, ip_address=None, gateway=None, networkmask=None): |
There was a problem hiding this comment.
set_not_required_if_none
There was a problem hiding this comment.
it was late, i need a parameter name and tadaaaaa! set_not_required_if_none
…_value_for_not_required_parameter'
Now you have to set networkmask and gateway or you have to use CIDR notation for the ip_address parameter
For the dhcp endpoints i implemented checks for mac and ipv4 adresses
The IP Objects are not json serializable, so we cast it to string
* You can set in the [Common] Section in the config the FQDN value for the hostname that will be used for configs. (if not provided, it will get by socket.fqdn())
the validation checks now for ipv4 or ipv4 cidr notation
|
i think we can merge this now, but somebody should test it before |
|
here was rubbish |
Now it is possible to user upper- or lower- or mixedcase mac addresses
bastelfreak
force-pushed
the
feat-isc-dhcp
branch
from
02ba4b7
to
f89aad7
Compare
|
tested locally, didn't found any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a new API endpoint, /dhcp, to add static ip/mac adresses