sevctl ok: Detect and use host arch's CPU generation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slp
reviewed
Mar 28, 2022
| @@ -46,7 +46,7 @@ Probes processor, sysfs, and KVM for AMD SEV, SEV-ES, and SEV-SNP related featur | |||
|
|
|||
| ```console | |||
| $ sevctl ok {sev, es, snp} // Probes support for the generation specified. | |||
| $ sevctl ok // Probes for SEV, SEV-ES, and SEV-SNP support. | |||
There was a problem hiding this comment.
I kind of feel like the original comment was easier to understand. Perhaps adding an (autodetected) to the end of it would be sufficient?
There was a problem hiding this comment.
I read that as Probes for SEV, SEV-ES, and SEV-SNP support regardless of the generation you're running on, which would no longer be the case with this update.
What about Probes for SEV, SEV-ES, and SEV-SNP based on the autodetected generation the host CPU is running on?
When the ok command is invoked without a processor generation specified, probe the host hardware for the current generation of AMD processor and test for that generation specifically. Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>
Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>
|
@slp there needed to be some conversion from the CPUID string to get an actual |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using sevctl ok without specifying a generation, allow the tool to determine the underlying processor's SEV generation and only include tests relevant to that specific generation.