Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation run logs should contain proper KISAO ids #108

Closed
jonrkarr opened this issue Oct 16, 2021 · 1 comment
Closed

Simulation run logs should contain proper KISAO ids #108

jonrkarr opened this issue Oct 16, 2021 · 1 comment
Assignees
@moraru @danv61

Comments

@jonrkarr
Copy link
Contributor

VCell logs presently have the : variant of KiSAO ids (e.g., KISAO:0000019). Let's use the true id with _ (e.g., KISAO_0000019).

This hasn't been detected because we don't have detailed validation of logs yet. This an open issue (biosimulations/biosimulations#2048).
danv61 added a commit that referenced this issue Oct 20, 2021
@danv61
Simulation run logs should contain proper KISAO ids.
32a6aa0 
Issue #108.
@danv61
Copy link
Contributor

danv61 commented Oct 20, 2021

Fixed in commit 32a6aa0.

@danv61 danv61 closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moraru moraru

@danv61 danv61

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonrkarr @moraru @danv61