Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostDefaults.Json Issue #33

Closed
DexterPOSH opened this issue Dec 2, 2015 · 3 comments
Closed

HostDefaults.Json Issue #33

DexterPOSH opened this issue Dec 2, 2015 · 3 comments
Labels

Comments

@DexterPOSH
Copy link
Contributor

The HostDefaults.json uses entries like below :

"ConfigurationPath": "%SYSTEMDRIVE%\TestLab\Configurations",

I was under the impression that when I run Start-LabHostConfiguration for the first time it will automatically create the required folders under the system drive. But the %SYSTEMDRIVE% is not being expanded in the path by the function.

This creates the directory in my current path rather than the System Drive.
labissue1

I can work on fixing it, if you confirm I am not doing it wrong.

@iainbrighton
Copy link
Contributor

Hi @DexterPOSH - that could well be a bug. It used to create the folders when running Set-LabHostDefaults, but that behaviour was changed.

Looking at the screenshots, it looks like there needs to be a ResolvePathEx -Path $property call just before the NewDirectory call to expand/resolve the path first. The Test-LabHostConfiguration method will probably need to be fixed too!

If you're happy to fix and sent a PR that'd be appreciated!

@DexterPOSH
Copy link
Contributor Author

Thanks @iainbrighton .
Fixing it now and will send a PR.

DexterPOSH added a commit to DexterPOSH/Lab that referenced this issue Dec 2, 2015
Fix for the Bug reported here :
VirtualEngine#33
@DexterPOSH DexterPOSH mentioned this issue Dec 2, 2015
@DexterPOSH
Copy link
Contributor Author

PR Created for the above bug.
#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants