Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework document root folder creation error handling #60

Closed
star-szr opened this issue Oct 16, 2014 · 0 comments · Fixed by #61
Closed

Rework document root folder creation error handling #60

star-szr opened this issue Oct 16, 2014 · 0 comments · Fixed by #61
Assignees
@star-szr

Comments

@star-szr
Copy link
Contributor

f3c4a55 doesn't work as expected, it actually dies even if creating the document root is successful. I'm going to revert it for now, so this issue is to track adding this back in a way that works better.
@star-szr star-szr self-assigned this Oct 16, 2014
@star-szr star-szr mentioned this issue Oct 16, 2014
Merged
star-szr added a commit that referenced this issue Oct 16, 2014
@star-szr
Die if we can't make our document root
7c2f351 
This didn't work well as a one-liner, breaking it out into a separate
if block.

Fixes #60.
@star-szr star-szr mentioned this issue Oct 16, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@star-szr star-szr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Die if we can't make our document root virtualhost/virtualhost.sh
1 participant
@star-szr