Sur row style #211
Merged
Sur row style #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackWilb
approved these changes
Mar 15, 2022
| const store = useContext(Store); | ||
|
|
||
| return (<SurgeryListComp | ||
| key={`${isSubSurgery ? parentSurgery! + '-' : ''}${listItem.procedureName}`} |
There was a problem hiding this comment.
parentSurgery! is not best practice. You should check if it exists above, and if not, you could throw an error.
Alternatively, you could either give it a default value if it's not specified (an empty string, perhaps) or require that it has a value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out surgery rows.
Expected behavior: the SVG will hide if the text overflows.