Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix screen grid layer crash in safari #2984

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Fix screen grid layer crash in safari #2984

merged 1 commit into from
Apr 15, 2019

Conversation

jianhuang01
Copy link
Contributor

For #2892

Change List

  • rename uniform

1chandu
1chandu approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@1chandu 1chandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find !!!
Is this due to any recent luma.gl change, if so, its good to double check other layer shaders too.

@coveralls
Copy link

coveralls commented Apr 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 62.467% when pulling 01e416c on fix-screen-grid-layer into 7f96cc3 on master.

@jianhuang01 jianhuang01 merged commit 280bca5 into master Apr 15, 2019
@jianhuang01 jianhuang01 deleted the fix-screen-grid-layer branch April 15, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsherif tsherif tsherif approved these changes

@1chandu 1chandu 1chandu approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jianhuang01 @coveralls @tsherif @1chandu