Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARTO: Initial implementation of v9 API #8167

Merged
merged 2 commits into from
Oct 5, 2023
Merged

CARTO: Initial implementation of v9 API #8167

merged 2 commits into from
Oct 5, 2023

Conversation

felixpalmer
Copy link
Collaborator

For #8047

Squashed and cherry-picked from 8.9 branch: #8130

Change List

  • Implementation of Source classes for all types of data sources
  • Rename _CartoTileLayer -> VectorTileLayer & export previously private Layers
  • Automatic injection of access token in Layers
  • Test app to show usage with all data types
  • Types for data sources and return values

padawannn
padawannn approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@padawannn padawannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@felixpalmer felixpalmer merged commit 1d7207d into master Oct 5, 2023
2 checks passed
@felixpalmer felixpalmer deleted the felix/carto-v9-api-squashed branch October 5, 2023 08:38
Pessimistress pushed a commit that referenced this pull request Oct 5, 2023
@felixpalmer @Pessimistress
CARTO: Initial implementation of v9 API (#8167)
a2b5690
@felixpalmer felixpalmer mentioned this pull request Oct 12, 2023
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padawannn padawannn padawannn approved these changes

@zbigg zbigg Awaiting requested review from zbigg

@alasarr alasarr Awaiting requested review from alasarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixpalmer @padawannn