Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carto: Initial implementation of v9 API #8130

Closed
wants to merge 48 commits into from

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Sep 21, 2023

For #8047

Background

READ FIRST: Implements RFC detailed here

Based off 8.9 to ease testing. This PR will not be merged into master until binary data handling is fixed in the VectorTileLayer

Change List

  • Implementation of Source classes for all types of data sources
  • Rename _CartoTileLayer -> VectorTileLayer & export previously private Layers
  • Automatic injection of access token in Layers
  • Test app to show usage with all data types
  • Types for data sources and return values

@felixpalmer felixpalmer marked this pull request as draft September 21, 2023 16:02
@alasarr
Copy link
Contributor

alasarr commented Sep 25, 2023

@padawannn @zbigg @VictorVelarde can you help me with the review of this PR?. I'm not going to be able to check until the end of the week and don't want to slow it down

@felixpalmer felixpalmer marked this pull request as ready for review September 28, 2023 15:11
@felixpalmer felixpalmer changed the title Draft: Carto v9 API Carto: Initial implementation of v9 API Sep 28, 2023
@felixpalmer felixpalmer mentioned this pull request Sep 29, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants