Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARTO v9 API tracker #8148

Closed
9 of 14 tasks
felixpalmer opened this issue Sep 29, 2023 · 5 comments
Closed
9 of 14 tasks

CARTO v9 API tracker #8148

felixpalmer opened this issue Sep 29, 2023 · 5 comments
Assignees
Labels

Comments

@felixpalmer
Copy link
Collaborator

felixpalmer commented Sep 29, 2023

Tracker for work needed to land the new API for interacting with the CARTO backend.

Tasks

@felixpalmer felixpalmer self-assigned this Sep 29, 2023
@felixpalmer felixpalmer added chore and removed feature labels Sep 29, 2023
@aaranadev
Copy link
Contributor

aaranadev commented Oct 3, 2023

About the RFC #8051, I have a doubt about React considerations.

Now the access_token is required into new source functions, so the access_token need to add as dependency in useMemo, I would like to see how the workflow is affected if access_token changes or if you add it to the dependency array.

For instance:

  • the access_token expires
  • the access_token is changed by the user

As far as I know, Maps API instantiation needs to be renewed.

cc: @menusal @VictorVelarde

@felixpalmer
Copy link
Collaborator Author

Now the access_token is required into new source functions, so the access_token need to add as dependency in useMemo, I would like to see how the workflow is affected if access_token changes or if you add it to the dependency array.

In the case of a changing access token, it would be included in the useMemo dependency Array, which as you say will then trigger a new instantiation

@aaranadev
Copy link
Contributor

Now the access_token is required into new source functions, so the access_token need to add as dependency in useMemo, I would like to see how the workflow is affected if access_token changes or if you add it to the dependency array.

In the case of a changing access token, it would be included in the useMemo dependency Array, which as you say will then trigger a new instantiation

Yes, perfect. I would like to test it when possible. Thx!

@felixpalmer
Copy link
Collaborator Author

@aaranadev we've come up with a pattern which avoids the need for using useMemo: #8214

@aaranadev
Copy link
Contributor

@aaranadev we've come up with a pattern which avoids the need for using useMemo: #8214

Oh great! I see the REQUEST_CACHE map being replaced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants