Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lighting module color format #1174

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Fix lighting module color format #1174

merged 1 commit into from
Jul 22, 2019

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Normalize specularColor (light colors are already normalized)

This will require surfaceColor passed into lighting_getLightColor to be normalized as well.
This is a breaking change.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.267% when pulling 970771b on x/lighting-color-normalization into 525d8b2 on master.

@Pessimistress Pessimistress merged commit 1d713b6 into master Jul 22, 2019
@Pessimistress Pessimistress deleted the x/lighting-color-normalization branch July 22, 2019 17:51
@Pessimistress Pessimistress mentioned this pull request Jul 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianhuang01 jianhuang01 jianhuang01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @jianhuang01