gltf: support compressed textures #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Apr 20, 2021
| const image = gltfTexture.texture.source.image; | ||
| let textureOptions; | ||
| let specialTextureParameters = {}; | ||
| if (image.compressed) { |
There was a problem hiding this comment.
Hmm, why do we need this logic? Add a comment?
Is this always needed for compressed textures? If we have a standardized format for compressed textures, can this just be handled in the Texture constructor so that we can pass in the texture and not have to handle this here?
There was a problem hiding this comment.
- Data structure we pass to Texture2D constructor is different:
- For ImageBitmap we need do pass
{data: image}; - For compressed texture we already have
imagewith data field{data: Buffer, compressed: true, mipmaps: false, ...};
- We add important parameter:
TEXTURE_MIN_FILTER. It has different value for compressed textures
|
I don't have permission for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Change List