Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(shadertools): Improved typing of shader passes #1823

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore(shadertools): Improved typing of shader passes #1823

merged 1 commit into from
Oct 19, 2023

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Oct 19, 2023 •
edited
Loading

For #

Background

  • First pass towards stricter typing and dealing with both uniforms and bindings.

Change List

  • Update all shader passes to use ShaderPass type and declare uniform types.
  • Improve PBRModule typing

@ibgreen ibgreen marked this pull request as ready for review October 19, 2023 16:34
@ibgreen ibgreen merged commit 59b58ef into master Oct 19, 2023
2 checks passed
@ibgreen ibgreen deleted the ib/shadermodule-types branch October 19, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibgreen