Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve filter for texture bindings #1831

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Improve filter for texture bindings #1831

merged 1 commit into from
Nov 10, 2023

Conversation

felixpalmer
Copy link
Collaborator

Followup to #1826

Background

#1826 doesn't work after minification as the constructor name changes. Use better filter, as suggested here

Change List

  • Filter out uniforms rather than hacky string match

@felixpalmer felixpalmer mentioned this pull request Nov 7, 2023
Merged
@ibgreen ibgreen merged commit 7adb00b into master Nov 10, 2023
1 of 2 checks passed
@ibgreen ibgreen deleted the felix/extract-module-bindings2 branch November 10, 2023 12:00
@felixpalmer felixpalmer mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixpalmer @ibgreen