babel-plugin-inline-webgl-constants v2.0.0-alpha.1 #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that require it Lerna builds `@luma.gl/constants` before building any packages that depend on it. This plugin uses LOCAL `@luma.gl/constants`, and will fail without it, so delay using the plugin until reaching a package depending on constants.
ibgreen
approved these changes
Dec 7, 2023
| ]; | ||
|
|
||
| // Lerna builds `@luma.gl/constants` before building any packages that depend | ||
| // on it. This plugin uses LOCAL `@luma.gl/constants`, and will fail without |
There was a problem hiding this comment.
Would it be better to just a pinned dependency on luma.gl/constants so we don't depend on the local copy?
This utility could just as well have been in its own repo, it was just a convenience to have it here, but since it seems to get involved in the overall build process that seems to create unnecessary problems.
There was a problem hiding this comment.
I don't imagine we add new GL constants often, but I suppose testing that more easily would the advantage of keeping it here? No strong preference there. With the plugin in this repo, I wasn't sure how to safely exclude it from yarn bootstrap dependency linking.
donmccurdy
deleted the
donmccurdy/babel-plugin-inline-webgl-constants-v2.0.0-alpha.1
branch
This was referenced Dec 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already published under 'beta' tag -- updating local files.
When used in our local workspace, the plugin imports the local
@luma.gl/constants, which means constants need to be built before using the plugin. I've worked around that issue by conditionally loading the plugin in Babel config, only when it's needed. Lerna builds in order, so we know that by the time we're building a module depending on constants, constants have already been built.