Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests for copyTextureToBuffer with Framebuffer input #1885

Conversation

donmccurdy
Copy link
Collaborator

Enables tests for CommandBuffer#copyTextureToBuffer where the source is a Framebuffer. I've removed references to the "bufferCreation" option, which doesn't appear to be implemented or perhaps necessary. Is it safe to say the destination buffer can be required when using this function?

Related:

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this method needs to create the buffer, but it could be tricky for the app to know how to allocate a buffer of the correct size. We may eventually want some support for size calculations somewhere...

@donmccurdy
Copy link
Collaborator Author

...it could be tricky for the app to know how to allocate a buffer of the correct size. We may eventually want some support for size calculations somewhere...

Agreed — though I think if the app doesn't know how to allocate the correct size, it also won't know how to read the result, so one or more utilities might be ideal.

@donmccurdy donmccurdy merged commit 6b2e7d7 into master Dec 18, 2023
2 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/test-command-buffer-copyTextureToBuffer-framebuffer branch December 18, 2023 20:01
@donmccurdy donmccurdy mentioned this pull request Dec 19, 2023
31 tasks
@donmccurdy donmccurdy added this to the 9.0.0 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants