Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shadertools): Improve ShaderModule typings #1891

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Dec 19, 2023

For #
Another stacked PR for ShaderInputs

Background

  • The ShaderInputs PR required a pass on shader module typings,
  • The sheer amount of code changes makes it desirable to land this first.
  • In particular types now distinguish clearly between a module's Props vs Uniforms types
  • (based on feedback that shadermodules should expose an abstract set of "props" that can be remapped against different uniforms without breaking apps, and if so particular attention should be given to the types of those abstract props as they are the surface towards the app).

Change List

  • Shader modules

  • Some cleanup of previous stacked PRs.

  • I am not happy with the 1% coverage drop in this PR, but I can't quite spot what is driving it.

@ibgreen ibgreen marked this pull request as ready for review December 19, 2023 21:16
@ibgreen ibgreen merged commit 88a73b4 into master Dec 20, 2023
1 of 2 checks passed
@ibgreen ibgreen deleted the ib/shader-typings branch December 20, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant