chore: Update to OpenJS recommended license headers, SPDX identifiers #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
changed the title
Comment on lines
+301
to
-304
| createVertexArray(props: VertexArrayProps): VertexArray { | ||
| return new WEBGLVertexArray(this, props); | ||
| } | ||
|
|
||
| override createVertexArray(props: VertexArrayProps): VertexArray { |
There was a problem hiding this comment.
Is it insignificant to drop override here?
There was a problem hiding this comment.
Depends on whether this is an abstract method etc. Confusingly I can't see a change in the base class that requires it, not sure why it came in, but it passed tsc and linter so should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #
Background
Change List