Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(webgl): Remove Renderbuffer usage #1987

Merged
merged 3 commits into from
Mar 4, 2024
Merged

chore(webgl): Remove Renderbuffer usage #1987

merged 3 commits into from
Mar 4, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 4, 2024 •
edited
Loading

For #

Background

  • Switch to depth textures when autocreating depthStencil attachments in Framebuffers
  • Reported as breaking for deck.gl

Change List

  • Switch to depth textures when autocreating depthStencil attachments in Framebuffers
  • Handle corner cases with texture creation, mipmap creation
  • Cleanup of messy texture code.

@ibgreen ibgreen marked this pull request as ready for review March 4, 2024 19:53
@ibgreen ibgreen merged commit 83a38a1 into master Mar 4, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/no-renderbuffer branch March 4, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibgreen