Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shadertools): strict null checks, satisfies shader module (9.1) #2018

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 12, 2024

For #

Background

  • deck.gl has requested that luma.gl implements typescript strictNullChecks options

Change List

  • apply strict null checks to shadertools module.
  • Refactor shader module objects to use const satisfies to avoid wiping out detailed type information by "assigning" the ShaderModule type to the object. (most of the "strict null" issues were related to shader module definitions so this was not just a better dev exp thing, but a relevant refactor).

@ibgreen ibgreen changed the title Ib/null shadertools chore(shadertools): strict null checks, satisfies shader module Mar 12, 2024
@ibgreen ibgreen marked this pull request as ready for review March 12, 2024 16:21
@ibgreen ibgreen changed the title chore(shadertools): strict null checks, satisfies shader module chore(shadertools): strict null checks, satisfies shader module (9.1) Mar 12, 2024
@ibgreen ibgreen merged commit d356b1a into master Mar 13, 2024
1 of 2 checks passed
@ibgreen ibgreen deleted the ib/null-shadertools branch March 13, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants