Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): Add 'devices' prop to DeviceTabs component #2020

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

donmccurdy
Copy link
Collaborator

Some features of Luma v9 do not yet work in WebGPU. To avoid having <DeviceTabs /> crash when WebGPU is selected on these examples, this PR adds a prop so that individual examples can opt out of WebGPU support until we're able to implement that.

@donmccurdy
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @donmccurdy and the rest of your teammates on Graphite Graphite

@donmccurdy donmccurdy requested a review from ibgreen March 12, 2024 18:36
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I trust you tested the examples and only added the exceptions where needed.

@donmccurdy donmccurdy merged commit 8a27179 into master Mar 12, 2024
2 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/feat-device-tabs-devices-prop branch March 12, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants